Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update prefer_typescript.yml #10069

Merged
merged 1 commit into from Jun 16, 2020
Merged

build: update prefer_typescript.yml #10069

merged 1 commit into from Jun 16, 2020

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Jun 16, 2020

SUMMARY

This fixes some uncommon issues with this workflow. According to trilom/file-changes-action#100 (comment), the master release should always be safe.

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @nytai @ktmud

@etr2460 etr2460 changed the title Update prefer_typescript.yml build: update prefer_typescript.yml Jun 16, 2020
nytai
nytai approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referencing master causes the action/container to be built on every request. Since this isn't our slowest workflow this shouldn't impact the experience, but something to keep in mind.

@etr2460
Copy link
Member Author

etr2460 commented Jun 16, 2020

good to know, thanks for the heads up! it still runs pretty fast like you said, but it's helpful to understand the implications

@etr2460 etr2460 merged commit 334bd6e into master Jun 16, 2020
@ktmud
Copy link
Member

ktmud commented Jun 16, 2020 •
edited

Sorry for chiming in late, but I think having a fixed version is also more about stability rather than speed. We don't want things suddenly break just because the dependent repo changed its API.

In the future, if we know a fix is in, we can simply use the latest good git SHA if it hasn't release to a new version yet.

@etr2460 etr2460 deleted the etr2460-patch-2 branch July 1, 2020 15:14
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@auxten
Update prefer_typescript.yml (apache#10069)
98e59d0
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etr2460 @ktmud @nytai @mistercrunch