Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: add TypeScript tracker generation script #10074

Merged
merged 1 commit into from Jun 17, 2020

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Jun 16, 2020

SUMMARY

This is an ad hoc script for regenerating the content of issue #10004. I'm committing it to the repo so that anyone can run it, and so that i don't need to keep ignoring it from my future PRs. This will be deleted once everything is migrated over to TypeScript.

This does not affect any application code, so this is still in JS (writing/running one-off scripts in TS is still somewhat tricky to get right, so i figured this was easiest)

TEST PLAN

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @ktmud @graceguo-supercat @john-bodley

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #10074 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10074      +/-   ##
==========================================
+ Coverage   70.49%   70.50%   +0.01%     
==========================================
  Files         585      585              
  Lines       31073    31074       +1     
  Branches     3185     3185              
==========================================
+ Hits        21905    21909       +4     
+ Misses       9058     9056       -2     
+ Partials      110      109       -1     
Flag Coverage Δ
#cypress 53.92% <ø> (+0.02%) ⬆️
#javascript 59.50% <ø> (ø)
#python 70.07% <ø> (+<0.01%) ⬆️
Impacted Files Coverage Δ
superset/views/core.py 76.35% <0.00%> (+0.01%) ⬆️
superset-frontend/src/SqlLab/actions/sqlLab.js 66.81% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a9ce5...f1d2531. Read the comment docs.

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@etr2460 etr2460 merged commit e3013ea into apache:master Jun 17, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants