Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [logging] add selected tab name into perf logging #10080

Merged
merged 1 commit into from Jun 22, 2020
Merged

chore: [logging] add selected tab name into perf logging #10080

merged 1 commit into from Jun 22, 2020

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jun 17, 2020 •
edited

SUMMARY

Add extra data into dashboard perf logging:

  • fix/add target tab name when user switch dashboard tab
  • add dashboard initial bootstrap data length

TEST PLAN

sample log data:
Screen Shot 2020-06-16 at 11 59 13 PM

@etr2460 @ktmud

@ktmud
Copy link
Member

ktmud commented Jun 22, 2020

Could you provide more context on why is this information useful and how can it be used to improve Superset?

@graceguo-supercat
Copy link
Author

graceguo-supercat commented Jun 22, 2020 •
edited

  • bootstrap data size is used to track and understand initial page load duration

  • Here is a sample dashboard which airbnb is building, to show Superset usage and stats. These information will help dashboard owners see how viewers explore his dashboard:
    screencapture-superset-d-musta-ch-superset-dashboard-14268-2020-06-22-09_38_15

ktmud
ktmud approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing! This dashboard perf dash looks awesome! Hopefully some day in the future Superset will have something similar built-in.

@graceguo-supercat graceguo-supercat merged commit 221f380 into apache:master Jun 22, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@auxten
[logging] add selected tab name into perf logging (apache#10080)
ad2352b
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktmud ktmud ktmud approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@graceguo-supercat @ktmud @mistercrunch