fix: dashboard should not add extra_filters onto chart annotation #10115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
force-pushed
the
gg-FixDashAnnotation
branch
from
57852c4
to
45a7487
Compare
6 tasks
Closed
3 tasks
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We used to be able to show filtered vs all data in the same chart by using annotation. See below is an example, region vs global.
But I recently found there was an issue introduced by #8057, where dashboard filter (extra_filters param) is applied to chart's annotation layer. This will cause chart and annotation layer both have same query, so we can't compare filtered data vs original annotation layer.
This PR is try to fix this issue, not passing dashboard filter parameters to chart's annotation layer.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after:
TEST PLAN
Manual test
ADDITIONAL INFORMATION
@ktmud @etr2460 @mistercrunch