Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix lint on superset/utils/core.py #10120

Merged
merged 4 commits into from Jun 26, 2020

Conversation

willbarrett
Copy link
Member

SUMMARY

Does what it says on the tin. Also removes a pylint disable for superset/utils/dict_import_export.py - that file was already passing.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Reviewers

@john-bodley @nytai @craig-rueda

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say, either pylint is catches lint really well nowadays, or optionally it missed lots before. Either way LGTM.

@willbarrett willbarrett merged commit df71fac into apache:master Jun 26, 2020
@willbarrett willbarrett deleted the wbarrett/lint-it-2 branch June 26, 2020 15:49
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* Fix lint on superset/utils/core.py

* black

* mypy

* Fix some missing renames
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants