Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix CTAS explore flow #10147

Merged
merged 1 commit into from Jun 24, 2020
Merged

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk commented Jun 24, 2020

Fixes the mistyped exploreChart function for the create table as explore view

To repro:

  1. Create a table using CTAS button
    image

  2. Click on the explore button
    image

Actual behavior: nothing happens on the click
Expected behavior: opens an explore page in the new tab

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro added the v0.37 label Jun 24, 2020
@bkyryliuk bkyryliuk merged commit 763b385 into apache:master Jun 24, 2020
@bkyryliuk bkyryliuk deleted the bogdan/fix_explore_cta branch June 24, 2020 05:36
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.37 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants