feat: Add new timegrains and convert_dttm to Druid engine spec #10160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
reviewed
Jun 25, 2020
villebro
commented
Jun 25, 2020
Comment on lines
+45
to
+48
| "PT5M": "TIME_FLOOR({col}, 'PT5M')", | ||
| "PT10M": "TIME_FLOOR({col}, 'PT10M')", | ||
| "PT15M": "TIME_FLOOR({col}, 'PT15M')", | ||
| "PT0.5H": "TIME_FLOOR({col}, 'PT30M')", |
There was a problem hiding this comment.
Added the intermediate grains between 1M and 1H.
dpgaspar
approved these changes
Jun 25, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…e#10160) * feat: Add new timegrains and convert_dttm to Druid engine spec * Add TemporalType enum and fix test case * Remove DATETIME for athena (original spec)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add missing intermediate time grains and
convert_dttmmethod to Druid engine spec.TEST PLAN
CI + new tests + tested locally
ADDITIONAL INFORMATION