build: enable typescript for cypress #10170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
commented
Jun 26, 2020
| @@ -72,7 +85,7 @@ describe('Dashboard filter', () => { | |||
|
|
|||
| cy.get('.Select__control input[type=text]') | |||
| .first() | |||
| .focus({ force: true }) | |||
There was a problem hiding this comment.
Type check helped by notifying me this is not a valid API for focus.
ktmud
commented
Jun 26, 2020
| filterId = | ||
| dashboard.slices.find( | ||
| slice => slice.form_data.viz_type === 'filter_box', | ||
| )?.slice_id || 0; |
There was a problem hiding this comment.
Fallback to 0 is easier than running assertions on a potential undefined.
ktmud
force-pushed
the
cypress-ts
branch
2 times, most recently
from
227baec
to
35d524d
Compare
|
Looks like CI is still breaking a bit, will review once fixed (i think you're missing installing an import) |
ktmud
force-pushed
the
cypress-ts
branch
2 times, most recently
from
a7f0708
to
3ce4fb0
Compare
Codecov Report
@@ Coverage Diff @@
## master #10170 +/- ##
==========================================
- Coverage 70.55% 70.39% -0.16%
==========================================
Files 594 190 -404
Lines 31464 18356 -13108
Branches 3226 0 -3226
==========================================
- Hits 22198 12922 -9276
+ Misses 9150 5434 -3716
+ Partials 116 0 -116
Continue to review full report at Codecov.
|
ktmud
commented
Jun 26, 2020
| "plugin:cypress/recommended" | ||
| ], | ||
| "rules": { | ||
| "import/no-unresolved": 0, |
There was a problem hiding this comment.
Some Cypress modules might not be available if you run eslint in the parent folder before npm install in cypress-base (which is what our CI does).
|
@etr2460 Fixed the tests and this is now ready for re-review. |
Follow up apache#10161 : - Enable TypeScript for Cypress - Convert support files to TS - Convert an example test (dashboard/filter.test.js) to TS - Upgrade TypeScript for both `cypress-base` and `superset-frontend` - Reenable Prefer TS check for `cypress-base`
Some modules might not be available when `eslint` in the parent folder before running `npm install` in the cypress folder.
etr2460
approved these changes
Jun 29, 2020
ktmud
added a commit
to ktmud/superset
that referenced
this pull request
Sep 18, 2020
Prefer TypeScript has stopped working since apache#10170 because of a [typo][1] in `jq` script. [1] https://github.com/apache/incubator-superset/pull/10170/files#diff-0f1a9bbd1316e385c51f8aba1583bd99R24
ktmud
added a commit
that referenced
this pull request
Sep 18, 2020
Prefer TypeScript has stopped working since #10170 because of a [typo](https://github.com/apache/incubator-superset/pull/10170/files#diff-0f1a9bbd1316e385c51f8aba1583bd99R24) in `jq` script. Also fix the `trilom/file-changes-action` GH Action version so the process can be more predictable.
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Prefer TypeScript has stopped working since apache#10170 because of a [typo](https://github.com/apache/incubator-superset/pull/10170/files#diff-0f1a9bbd1316e385c51f8aba1583bd99R24) in `jq` script. Also fix the `trilom/file-changes-action` GH Action version so the process can be more predictable.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up #10161 :
cypress-baseCurrentlycypress-baseis now using a newer version of TypeScript thansuperset-frontend. Will file another PR to upgrade later.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
All Cypress tests should still be valid and pass.
cc @etr2460