chore: type ResultSet.tsx #10226
Merged
chore: type ResultSet.tsx #10226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
commented
Jul 2, 2020
| @@ -387,7 +387,7 @@ export const stoppedQuery = { | |||
| startDttm: 1497400851936, | |||
| state: 'stopped', | |||
| tab: 'Untitled Query 2', | |||
| tempTableName: '', | |||
| tempTable: '', | |||
There was a problem hiding this comment.
I aligned on this name everywhere because that's how the backend sends it
Comment on lines
-221
to
-228
| // Async queries | ||
| let tmpSchema = query.tempSchema; | ||
| let tmpTable = query.tempTableName; | ||
| // Sync queries, query.results.query contains the source of truth for them. | ||
| if (query.results && query.results.query) { | ||
| tmpTable = query.results.query.tempTable; | ||
| tmpSchema = query.results.query.tempSchema; | ||
| } |
There was a problem hiding this comment.
this logic is moved to the reducer, it seems cleaner (although it's a big janky to have the query in 2 different places here)
| @@ -235,20 +236,21 @@ export default class ResultSet extends React.PureComponent { | |||
| <Alert bsStyle="info"> | |||
| {t(object)} [ | |||
| <strong> | |||
| {tmpSchema}.{tmpTable} | |||
| {tempSchema ? `${tempSchema}.` : ''} | |||
There was a problem hiding this comment.
When testing on sqllite, there wasn't always a schema, so i cleaned up the cases where schema can be null
etr2460
force-pushed
the
erik-ritter--type-resultset
branch
from
37f0968
to
01db9f8
Compare
mistercrunch
approved these changes
Jul 2, 2020
|
Thanks for the quick stamps! I'm going to wait for @bkyryliuk to take a look as well since the CTAS logic was the main functional change here and i want to make sure it looks good to him |
bkyryliuk
approved these changes
Jul 2, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As titled. Also includes a couple small refactors/bug fixes that i came across as I was working
TEST PLAN
CI
ADDITIONAL INFORMATION
to: @ktmud @graceguo-supercat @nytai @bkyryliuk