New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dataset api endpoint for charts and dashboards count #10235
feat: dataset api endpoint for charts and dashboards count #10235
Conversation
315a54f
to
988a1b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #10235 +/- ##
===========================================
- Coverage 70.31% 53.38% -16.93%
===========================================
Files 594 343 -251
Lines 31608 11419 -20189
Branches 3221 2848 -373
===========================================
- Hits 22225 6096 -16129
+ Misses 9275 5143 -4132
- Partials 108 180 +72
Continue to review full report at Codecov.
|
It could be good to be able to show a list of related objects instead of counts as users may want to go and alter those objects to point them to a new place. The UI can still just show the counts, but the endpoint would be more useful that way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, but I think that the OpenAPI spec is no correct, check it on \swaggerview\v1
content: | ||
application/json: | ||
schema: | ||
type: object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema:
type: object
properties:
dashboard_count:
type: integer
chart_count:
type: integer
00fb48f
to
371e153
Compare
371e153
to
37d3306
Compare
1a633d3
to
6cbbda5
Compare
6cbbda5
to
c7d96d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION