fix(table-viz): JS error when sort time column #10250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix
getTime
undefined error when sorting a time column in table chart. Also refactors how datetime is handled forreact-table
search, sort and render methods.Fix spacing issue for table pagination in dashboards
Before:
After:
Related: apache-superset/superset-ui#669
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See SUMMARY.
TEST PLAN
Unit test in superset-ui and E2E test in superset-frontend.
ADDITIONAL INFORMATION