Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: datasets related objects, apply filter and openapi spec #10252

Merged
merged 4 commits into from Jul 8, 2020
Merged

fix: datasets related objects, apply filter and openapi spec #10252

merged 4 commits into from Jul 8, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jul 7, 2020

SUMMARY

Applies filter on datasets related object and simplifies OpenApi spec using mashmallow schemas

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar changed the title fix, datasets related objects, apply filter and openapi spec fix: datasets related objects, apply filter and openapi spec Jul 7, 2020
@dpgaspar dpgaspar marked this pull request as ready for review July 7, 2020 15:44
@dpgaspar dpgaspar requested a review from villebro July 7, 2020 15:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2020 •
edited

Codecov Report

Merging #10252 into master will decrease coverage by 4.71%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10252      +/-   ##
==========================================
- Coverage   70.16%   65.44%   -4.72%     
==========================================
  Files         598      598              
  Lines       31949    31965      +16     
  Branches     3223     3223              
==========================================
- Hits        22418    20921    -1497     
- Misses       9424    10863    +1439     
- Partials      107      181      +74
Flag Coverage Δ
#cypress ?
#javascript 59.47% <ø> (ø)
#python 69.60% <100.00%> (-0.03%) ⬇️
Impacted Files Coverage Δ
superset/datasets/api.py 92.02% <100.00%> (+2.82%) ⬆️
superset/datasets/schemas.py 94.20% <100.00%> (+2.04%) ⬆️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/SqlLab/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878dbcd...d6a7583. Read the comment docs.

@dpgaspar dpgaspar added the v0.37 label Jul 7, 2020
villebro
villebro approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 7ecff0e into apache:master Jul 8, 2020
@dpgaspar dpgaspar deleted the fix/api-datasets-related branch July 8, 2020 09:04
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@dpgaspar @auxten
fix: datasets related objects, apply filter and openapi spec (apache#…
a2432ff 
…10252)

* fix, datasets related objects, apply filter and openapi spec

* fix, add 404 test

* fix, add 404 test

* fix test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L v0.37 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dpgaspar @codecov-commenter @villebro @mistercrunch