feat(chart-data-api): make pivoted columns flattenable #10255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
reviewed
Jul 8, 2020
villebro
force-pushed
the
villebro/pivot-columns
branch
2 times, most recently
from
3271d0c
to
c4ae7da
Compare
villebro
force-pushed
the
villebro/pivot-columns
branch
from
c4ae7da
to
7d3a7b3
Compare
dpgaspar
approved these changes
Jul 8, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* feat(chart-data-api): make pivoted columns flattenable * Linting + improve tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the pivot operation doesn't work properly on the chart data endpoint due to column names being
Tuple[str, ...], causingjson.dumpsto fail. This adds the option to flatten the column names in a similar manner to howviz.pydoes it (drop metric name if only single metric present, join column names with comma etc). In addition, the index is returned to the DataFrame as a regular column to keep the pivot output uniform with other post processing operations. Thecolumnsargument is also made optional to avoid having to do an additional ternary inbuildQuerywhen building time series viz plugins with optional groupbys.TEST PLAN
CI + new tests
ADDITIONAL INFORMATION