Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue in getting filter_box config #10262

Merged
merged 1 commit into from Jul 9, 2020
Merged

fix: issue in getting filter_box config #10262

merged 1 commit into from Jul 9, 2020

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jul 9, 2020 •
edited

SUMMARY

Fix another bug from #10210 :(

ADDITIONAL INFORMATION

@etr2460 @ktmud

etr2460
etr2460 approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes! I wonder if TypeScript would've caught this...

@graceguo-supercat graceguo-supercat merged commit ab5ce82 into apache:master Jul 9, 2020
serenajiang pushed a commit to airbnb/superset-fork that referenced this pull request Jul 9, 2020
@serenajiang
fix: issue in getting filter_box config (apache#10262)
17b4244
@graceguo-supercat graceguo-supercat deleted the gg-FixSearchAllOptions-2 branch November 11, 2020 23:17
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@auxten
fix: issue in getting filter_box config (apache#10262)
a33a7b9
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@graceguo-supercat @etr2460 @mistercrunch