New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show formatted date instead of epoch on results #10268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Does this table use the new chart data API? What about other datetime columns? If I'm understanding the code right, all datetime columns will return epochs? I think it would be best if the new API response payload will include data type info, what do you think? And how about replacing this table with the TableChart? There seems to be some overlapping work here. |
@ktmud this is only being used on the |
Oh sorry @ktmud , I hadn't seen that PR, cool! Yeah, let's use that info once that PR gets merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making it human-readable, and thanks for the tests.
Hi guys, i'm pretty new to Superset and have recently upgraded to superset 1.1 and i am getting the UNIX timestamp in filter box. Could you please suggest how to resolve it. |
Same problem here |
@PiyushGupta3108 @musthak24 this is a known limitation of Filter Box. Since Filter Box is in the process of being deprecated, and the native value filter properly formats timestamps, I don't expect this to be fixed. If you want to enable native filters, just enable the |
SUMMARY
When pressing "View results" on Explore View, the primary temporal column is displayed as epochs. This applies a typical
%Y-%m-%d %H:%M:%S
format to the__timestamp
column to make the results slightly more legible.BEFORE
AFTER
TEST PLAN
CI + new tests
ADDITIONAL INFORMATION