fix: pin slack client, breaking change

[bkyryliuk]

Slack client versions > 2.5.0 do not accept the file content anymore. It broke the slack integration.
Added test that would capture undesired upgrades.
Eventually we can fix via writing a tmp file and then uploading it.

TEST PLAN

• ipython
• unit test
• dropbox staging

[codecov-commenter]

Codecov Report

Merging #10345 into master will decrease coverage by 11.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #10345       +/-   ##
===========================================
- Coverage   70.61%   59.47%   -11.15%     
===========================================
  Files         601      405      -196     
  Lines       32225    13269    -18956     
  Branches     3257     3257               
===========================================
- Hits        22757     7892    -14865     
+ Misses       9365     5196     -4169     
- Partials      103      181       +78     

Flag	Coverage Δ
#cypress	?
#javascript	59.47% <ø> (+<0.01%)	⬆️
#python	?

Impacted Files	Coverage Δ
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupColors.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/chart/ChartContainer.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupFormatters.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/reducers/index.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupPluginsExtra.js	0.00% <0.00%> (-100.00%)	⬇️
... and 340 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c9c73...bdd31b3. Read the comment docs.

[villebro]

@bkyryliuk do I understand correctly that the new version doesn't support file-like objects, but requires files to be persisted to disk prior to submission?

[bkyryliuk]

@bkyryliuk do I understand correctly that the new version doesn't support file-like objects, but requires files to be persisted to disk prior to submission?

yes
I did not dig much into the changes in the lib. We have been using 2.5.0 for last 3 month at dropbox.
I used this snippet in ipython to find the version that had the regression

import logging
logging.basicConfig(level=logging.DEBUG)

import os
from slack import WebClient
from slack.errors import SlackApiError
slack_token='your_token'
client = WebClient(token=slack_token)
fn = '/Users/bogdankyryliuk/Desktop/Screen Shot 2020-07-16 at 9.03.49 AM.png'
in_file = open(fn, "rb")
data = in_file.read()
response = client.files_upload(
  channels="#bogdan-test2",
  file=data,
  title="Test upload"
)

[mistercrunch]

Had the issue been reported on their GitHub? If so can we link to it? If not can we report it?

[villebro]

slackapi/python-slack-sdk#728

Seems like making it a file-like object (io.BytesIO) instead of bytearray fixes it in >2.5.0, <2.7.2. Since 2.7.2 is already out, we should probably bump to that version?

[villebro]

Check my comment above. I propose bumping to 2.7.2.

[bkyryliuk]

slackapi/python-slackclient#728

Seems like making it a file-like object (io.BytesIO) instead of bytearray fixes it in >2.5.0, <2.7.2. Since 2.7.2 is already out, we should probably bump to that version?

This seems to work:

 response = client.files_upload(channels="#bogdan-test2", file=io.BytesIO(b'blabla'), title="Test upload", filename="test.png")

I am on PTO today, won't be able to test this approach on our staging.
My suggestion here would be to merge the library downgrade and I can do a fix forward a bit later this week.

[villebro]

To get this unblocked for 0.37, in discussions with @bkyryliuk we decided to get this merged and follow up with a 2.7.2 bump later after it has been properly tested at Dropbox.