feat: support non-numeric columns in pivot table #10389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
approved these changes
Jul 28, 2020
villebro
force-pushed
the
villebro/pivot-table-non-numeric
branch
from
f6b0d09
to
8009b0f
Compare
|
Thanks @mistercrunch; broke out function and added unit tests |
villebro
changed the title
villebro
changed the title
villebro
added a commit
that referenced
this pull request
Jul 28, 2020
* fix: support non-numeric columns in pivot table * bump package and add unit tests * mypy
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix: support non-numeric columns in pivot table * bump package and add unit tests * mypy
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix: support non-numeric columns in pivot table * bump package and add unit tests * mypy
mistercrunch
added
🍒 0.37.0
🍒 0.37.1
🍒 0.37.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds support for non-numeric metrics in pivot table. Since only
minandmaxaggregation works for non-numeric dtypes in Pandas, choosing any other aggregator will default tomax.Related PR: apache-superset/superset-ui#695
BEFORE
AFTER
TEST PLAN
ADDITIONAL INFORMATION