Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect filter operator emitted by Filter Box #10421

Merged
merged 6 commits into from Jul 26, 2020
Merged

fix: incorrect filter operator emitted by Filter Box #10421

merged 6 commits into from Jul 26, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented Jul 24, 2020 •
edited

SUMMARY

Fix error caused by incorrect filter operator type definitions and time_range_endpoints character case in OpenAPI spec. Dependent on apache-superset/superset-ui#700 .

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI + local testing

ADDITIONAL INFORMATION

  • Has associated issue: closes Invalid filter operation type: = #10414
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro changed the title [WIP] fix incorrect filter operator emitted by Filter Box fix: incorrect filter operator emitted by Filter Box Jul 24, 2020
graceguo-supercat
graceguo-supercat approved these changes Jul 25, 2020
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit 5b6ff49 into apache:master Jul 26, 2020
@villebro villebro added the v0.37 label Jul 26, 2020
@villebro villebro deleted the villebro/fix-extra-filters branch July 26, 2020 11:50
villebro added a commit that referenced this pull request Jul 26, 2020
@villebro
fix: incorrect filter operator emitted by Filter Box (#10421)
7b6f88a 
* fix: equals operator in filter box

* fix time range endpoint schema

* fix test

* bump packages

* fix tests

* lint
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@villebro @auxten
fix: incorrect filter operator emitted by Filter Box (apache#10421)
fdf4c7d 
* fix: equals operator in filter box

* fix time range endpoint schema

* fix test

* bump packages

* fix tests

* lint
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@villebro
fix: incorrect filter operator emitted by Filter Box (apache#10421)
9e0f584 
* fix: equals operator in filter box

* fix time range endpoint schema

* fix test

* bump packages

* fix tests

* lint
@mistercrunch mistercrunch added 🍒 0.37.0 🍒 0.37.1 🍒 0.37.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v0.37 🍒 0.37.0 🍒 0.37.1 🍒 0.37.2 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid filter operation type: =
3 participants
@villebro @graceguo-supercat @mistercrunch