chore: Migrating reports to AuthWebdriverProxy #10567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig-rueda
changed the title
Codecov Report
@@ Coverage Diff @@
## master #10567 +/- ##
==========================================
- Coverage 63.97% 59.71% -4.26%
==========================================
Files 768 770 +2
Lines 36357 36368 +11
Branches 3431 3431
==========================================
- Hits 23259 21718 -1541
- Misses 12985 14458 +1473
- Partials 113 192 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…-webdrivers # Conflicts: # superset/tasks/slack_util.py
craig-rueda
commented
Aug 11, 2020
| @@ -0,0 +1,190 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Moving all things webdriver into a central location
craig-rueda
commented
Aug 11, 2020
dpgaspar
reviewed
Aug 11, 2020
dpgaspar
reviewed
Aug 11, 2020
dpgaspar
reviewed
Aug 11, 2020
dpgaspar
requested changes
Aug 11, 2020
…-webdrivers # Conflicts: # superset/tasks/schedules.py
dpgaspar
requested changes
Aug 12, 2020
scripts/tests/run.sh
Outdated
| } | ||
|
|
||
| # | ||
| # Init global vars | ||
| # | ||
| DB_NAME="test" | ||
| DB_NAME="superset" |
There was a problem hiding this comment.
This is not correct, the intend here is to use a separate DB and having a simple way to DROP/CREATE it at will
superset/utils/webdriver.py
Outdated
| def auth(self, user: "User") -> WebDriver: | ||
| driver = self.create() | ||
| # Setting cookies requires doing a request first | ||
| driver.get(headless_url("/login/")) |
There was a problem hiding this comment.
Can we remove this from here and place it inside machine_auth_provider_factory.instance.authenticate_webdriver(driver, user)
dpgaspar
reviewed
Aug 12, 2020
There was a problem hiding this comment.
LGTM, we have a couple of breaking changes here, so let's update UPDATING.md. Check if we need to update docs also.
@bkyryliuk I think your review would be very useful here
dpgaspar
approved these changes
Aug 12, 2020
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
* Migrating reports to AuthWebdriverProxy * Extracting out webdriver proxy / Adding thumbnail tests to CI * Adding license * Adding license again * Empty commit * Adding thumbnail tests to CI * Switching thumbnail test to Postgres * Linting * Adding mypy:ignore / removing thumbnail tests from CI * Putting ignore statement back * Updating docs * First cut at authprovider * First cut at authprovider mostly working - still needs more tests * Auth provider tests added * Linting * Linting again... * Linting again... * Busting CI cache * Reverting workflow change * Fixing dataclasses * Reverting back to master * linting? * Reverting installation.rst * Reverting package-lock.json * Addressing feedback * Blacking * Lazy logging strings * UPDATING.md note
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* Migrating reports to AuthWebdriverProxy * Extracting out webdriver proxy / Adding thumbnail tests to CI * Adding license * Adding license again * Empty commit * Adding thumbnail tests to CI * Switching thumbnail test to Postgres * Linting * Adding mypy:ignore / removing thumbnail tests from CI * Putting ignore statement back * Updating docs * First cut at authprovider * First cut at authprovider mostly working - still needs more tests * Auth provider tests added * Linting * Linting again... * Linting again... * Busting CI cache * Reverting workflow change * Fixing dataclasses * Reverting back to master * linting? * Reverting installation.rst * Reverting package-lock.json * Addressing feedback * Blacking * Lazy logging strings * UPDATING.md note
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR merges the functionality found in the reports scheduling Webdriver creation with the logic found in Thumbnails. The Thumbnails version allows for option overriding where necessary and is in general superior to that found in scheduling.
get_auth_cookies(User)method viaMACHINE_AUTH_PROVIDER_CLASSconfig option