Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate python 3.6 support #10803

Merged
merged 1 commit into from Sep 9, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented Sep 6, 2020

SUMMARY

With Python 3.7 having been released over 2 years ago and recently entered 'security fix' mode, along with the dataclasses backport package no longer supporting Python 3.7 as of version 0.7, it's time to deprecate support for python 3.6 to be able to take full advantage of new features in 3.7, and prepare for moving to Python 3.8 and onwards.

Changes introduced by this PR:

  • removes 3.6 from the CI build matrix
  • removes dataclasses dependency from `setup.py
  • replaces Python 3.6 with 3.7 in all Dockerfiles

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI + local testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
Copy link
Member Author

villebro commented Sep 6, 2020

Related INFRA ticket: https://issues.apache.org/jira/browse/INFRA-20823

@mistercrunch
Copy link
Member

Let's mention this in UPDATING.md!

@villebro villebro merged commit 9a66971 into apache:master Sep 9, 2020
@villebro villebro deleted the villebro/deprecate-py36 branch September 9, 2020 05:52
@villebro villebro added v0.38 and removed v0.38 labels Sep 10, 2020
@cyw233
Copy link
Contributor

cyw233 commented Sep 11, 2020

Thanks for the update! I think we also need to change these two lines to 3.7 in the Dockerfile. Cheers.
to_37

@villebro
Copy link
Member Author

Good catch! I thought I got them all 🙁 Would you mind opening a PR to fix this?

@cyw233
Copy link
Contributor

cyw233 commented Sep 11, 2020

Sure let me do it now

dpgaspar pushed a commit to preset-io/superset that referenced this pull request Sep 16, 2020
@dpgaspar dpgaspar added the v0.38 label Sep 22, 2020
dpgaspar pushed a commit that referenced this pull request Sep 22, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v0.38 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants