Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in docs #11129

Merged
merged 1 commit into from Oct 22, 2020
Merged

fix: typo in docs #11129

merged 1 commit into from Oct 22, 2020

Conversation

curlup
Copy link
Contributor

@curlup curlup commented Oct 1, 2020

SUMMARY

fixed a typo in docs on CORS

@etr2460 etr2460 changed the title typo in docs fix: typo in docs Oct 1, 2020
@etr2460
Copy link
Member

etr2460 commented Oct 1, 2020

Thanks for fixing the typo!

@nytai nytai closed this Oct 22, 2020
@nytai nytai reopened this Oct 22, 2020
@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #11129 into master will decrease coverage by 6.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11129      +/-   ##
==========================================
- Coverage   65.86%   58.93%   -6.93%     
==========================================
  Files         826      800      -26     
  Lines       38979    38556     -423     
  Branches     3669     3450     -219     
==========================================
- Hits        25673    22724    -2949     
- Misses      13196    15662    +2466     
- Partials      110      170      +60     
Flag Coverage Δ
#cypress 55.86% <ø> (-0.70%) ⬇️
#javascript ?
#python 60.61% <ø> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-89.19%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rset-frontend/src/profile/components/Favorites.tsx 0.00% <0.00%> (-86.67%) ⬇️
... and 365 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d8040...2dba924. Read the comment docs.

@nytai nytai merged commit 6f85d8d into apache:master Oct 22, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants