chore: turn SQL templating off by default #11172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
changed the title
dpgaspar
changed the title
willbarrett
approved these changes
Oct 6, 2020
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
bkyryliuk
approved these changes
Oct 6, 2020
etr2460
reviewed
Oct 7, 2020
UPDATING.md
Outdated
| @@ -23,6 +23,8 @@ assists people when migrating to a new version. | |||
|
|
|||
| ## Next | |||
|
|
|||
| * [10887](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS` | |||
There was a problem hiding this comment.
while you're in here, could you move the existing Next stuff to 0.37.2? Looks like that wasn't done yet.
Also, make sure you update the PR number
There was a problem hiding this comment.
Just checked, and the UPDATING is absolutely correct, there are no warning or breaking changes on 0.37.2
There was a problem hiding this comment.
ah, gotcha. i forgot that 0.37.2 was only cherrypicked PRs
…fix/disable-sql-templates # Conflicts: # UPDATING.md
Codecov Report
@@ Coverage Diff @@
## master #11172 +/- ##
==========================================
- Coverage 65.57% 61.49% -4.09%
==========================================
Files 828 828
Lines 39162 39164 +2
Branches 3694 3589 -105
==========================================
- Hits 25681 24084 -1597
- Misses 13371 14900 +1529
- Partials 110 180 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
approved these changes
Oct 7, 2020
|
@dpgaspar I think it's OK to merge this once conflicts are resolved |
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* feat: possible to turn off SQL templating * turn SQL templating off by default * Update UPDATING.md Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * fix missing PR number * fix missing PR number Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Jul 14, 2022
In the 1.0 release of superset template processing was changed from default enabled to default disabled[1]. Turn this back on as templating is useful in a variety of situations to build more dynamic and more efficient dashboards. [1] apache/superset#11172) Bug: T312134 Change-Id: I984d4ee70154e3cb83255fec043360d5dd28fa7e
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use a new feature flag to make it possible to enable/disable SQL templating.
Note:
Setting is off by default
ADDITIONAL INFORMATION