feat: home screen mvp #11206

pkdotson · 2020-10-08T21:47:40Z

SUMMARY

This PR introduces the new homescreen that the user will first interact with on login. The pr also decouples the card components from chartlist and dashboardlist components so that they both can be used more readily throughout homescreen.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Test Plan includes unit test and end to end test which are in development and will be updated during this review.

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Requires DB Migration.
Confirm DB Migration upgrade and downgrade tested.
[x ] Introduces new feature or API
Removes existing feature or API

codecov-io · 2020-10-08T22:03:07Z

Codecov Report

Merging #11206 into master will decrease coverage by 0.04%.
The diff coverage is 62.55%.

@@            Coverage Diff             @@
##           master   #11206      +/-   ##
==========================================
- Coverage   66.61%   66.56%   -0.05%     
==========================================
  Files         862      869       +7     
  Lines       41215    41587     +372     
  Branches     3719     3797      +78     
==========================================
+ Hits        27454    27684     +230     
- Misses      13660    13801     +141     
- Partials      101      102       +1

Flag	Coverage Δ
#cypress	`55.81% <20.72%> (-0.62%)`	⬇️
#javascript	`62.57% <59.71%> (-0.13%)`	⬇️
#python	`62.03% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/views/CRUD/data/common.ts	`100.00% <ø> (ø)`
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx	`61.83% <ø> (ø)`
superset/charts/api.py	`76.98% <ø> (ø)`
superset/dashboards/api.py	`82.87% <ø> (ø)`
superset/queries/api.py	`100.00% <ø> (ø)`
superset-frontend/src/views/CRUD/hooks.ts	`63.77% <27.02%> (-15.11%)`	⬇️
superset-frontend/src/views/CRUD/utils.tsx	`50.00% <30.50%> (-50.00%)`	⬇️
...-frontend/src/views/CRUD/welcome/ActivityTable.tsx	`46.47% <46.47%> (ø)`
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx	`60.00% <52.94%> (-16.00%)`	⬇️
...frontend/src/views/CRUD/welcome/DashboardTable.tsx	`60.37% <58.82%> (-18.58%)`	⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3dca4...3af819d. Read the comment docs.

superset-frontend/src/views/CRUD/welcome/EmptyState.tsx

rusackas

Lots of little things noted... some more important than others, obviously. Thanks for putting this feature together!

superset-frontend/spec/javascripts/views/CRUD/welcome/DashboardTable_spec.tsx

superset-frontend/spec/javascripts/views/CRUD/welcome/ChartTable_spec.tsx

superset-frontend/src/views/CRUD/welcome/ChartTable.tsx

superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx

rusackas · 2020-10-22T07:20:36Z

A few other little things that we discussed in person. They should not be blockers here, and could be followed up on other PRs, but I wanted to put them "on paper":

It would be great to share/reuse the media queries with cards (keeping it DRY), so they benefit other card views.
Maybe instead of living in superset-frontend/src/views/CRUD/welcome it should live in superset-frontend/src/views/welcome as its own thing.
If _may be of benefit to decouple all the card variants (Recent/Chart/Dashboard/SavedQuery/(eventually...)SearchResult). If doing so, then they should all probably continue to use the common ListVIewCard under the hood, which could be renamed as BaseCard or similar. All of these could live in the main components directory, perhaps hierarchically nested.

superset-frontend/src/views/CRUD/utils.tsx

nytai · 2020-10-27T01:30:47Z

superset-frontend/src/components/ListViewCard/index.tsx

+  actions: React.ReactNode | null;
+  showImg?: boolean;
+  rows?: number | string;
+  avatar?: string;


nit: this should be IconName or IconProps["name"].

superset-frontend/src/views/CRUD/hooks.ts

superset-frontend/src/components/ListViewCard/index.tsx

superset-frontend/src/views/CRUD/utils.tsx

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx

superset-frontend/src/views/CRUD/welcome/EmptyState.tsx

superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx

superset-frontend/src/views/CRUD/chart/ChartCard.tsx

superset-frontend/spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx

superset-frontend/src/components/Menu/SubMenu.tsx

superset-frontend/src/views/CRUD/welcome/EmptyState.tsx

nytai · 2020-10-27T22:19:06Z

FYI, @riahk also created an empty list state in #11432

…spec.tsx Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>

rusackas · 2020-10-29T18:36:55Z

Couldn't continue with reviewing because this PR really needs a rebase. The diff is too large.

After rebasing, you should have only 35 changed files instead of 119.
master...ktmud:home-screen-mvp

All cleared up now, back to 34 files. Thanks for your input so far. Good to have fresh eyes on this.

rusackas

OK... I think this thing is ready to go. Seems like all the serious concerns have been addressed. Plenty more great suggestions from those who have taken the time to review this (thank you!). I think any remaining suggestions/advice can be followed up on in subsequent PRs.

ktmud · 2020-10-30T06:08:08Z

A huge milestone! Thanks for all the great work @pkdotson and bearing with the back and forth. Looking forward to more exciting improvements to come!

junlincc · 2020-10-30T13:58:52Z

🥺 thank you @pkdotson so proud of you!!

* step 1: broken stuff! * first steps * more adding and slicing * step 1: broken stuff! * can now filter dashboards/charts for "Edited" tabs (filter by changed_by o_m) * more updates * update recent card * add icon * Adding Expand Icon to Collapse component * more updates * clean up code * remove lock file * remove consoles * fixing subnav button height shift * lil' ascii arrows * update branch * update test part 1 * remove consoles * fix typescript * add images and update emptystate * add changes * update chart card * fix css issues from rebase * add suggestions * more changes * update tests and clear typescript errors * Update superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * update from comments * more updates.. * fix rebase * fix pesky type errors * test fixes * lint fix * Update superset-frontend/spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/views/CRUD/welcome/EmptyState.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/components/Menu/SubMenu.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/components/ListViewCard/index.tsx Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com> * Update superset-frontend/src/components/ListViewCard/index.tsx Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com> * add suggestions * fix lint * remove unused code * toast getrecentActivityobjs * add some suggestions * remove types for now * cypress fix * remove unused type Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>

superset-github-bot bot added the preset-io label Oct 8, 2020

pull-request-size bot added the size/XXL label Oct 8, 2020

pkdotson force-pushed the home-screen-mvp branch from 5ac56e5 to 641f5c5 Compare October 19, 2020 20:56

pkdotson marked this pull request as ready for review October 19, 2020 21:21

junlincc requested review from rusackas, nytai, suddjian and ktmud October 19, 2020 21:50

rusackas reviewed Oct 21, 2020

View reviewed changes

superset-frontend/src/views/CRUD/welcome/EmptyState.tsx Outdated Show resolved Hide resolved

rusackas reviewed Oct 21, 2020

View reviewed changes

superset-frontend/src/views/CRUD/welcome/EmptyState.tsx Outdated Show resolved Hide resolved

pkdotson force-pushed the home-screen-mvp branch from 410993c to cb140ed Compare October 21, 2020 22:57

junlincc requested review from mistercrunch and removed request for suddjian October 21, 2020 23:47

rusackas requested changes Oct 22, 2020

View reviewed changes

hughhhh self-requested a review October 22, 2020 16:27

mistercrunch reviewed Oct 22, 2020

View reviewed changes

superset-frontend/src/views/CRUD/utils.tsx Outdated Show resolved Hide resolved

pkdotson force-pushed the home-screen-mvp branch from 54949b7 to 8edf056 Compare October 26, 2020 04:59

pkdotson requested review from rusackas and mistercrunch October 26, 2020 05:26

nytai reviewed Oct 27, 2020

View reviewed changes

rusackas reviewed Oct 27, 2020

View reviewed changes

superset-frontend/spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx Outdated Show resolved Hide resolved

rusackas reviewed Oct 27, 2020

View reviewed changes

superset-frontend/src/components/Menu/SubMenu.tsx Outdated Show resolved Hide resolved

rusackas reviewed Oct 27, 2020

View reviewed changes

superset-frontend/src/views/CRUD/welcome/EmptyState.tsx Outdated Show resolved Hide resolved

pkdotson closed this Oct 28, 2020

pkdotson reopened this Oct 28, 2020

rusackas self-requested a review October 28, 2020 22:27

pkdotson force-pushed the home-screen-mvp branch from 6fb9516 to 8924264 Compare October 28, 2020 22:28

pkdotson and others added 15 commits October 29, 2020 11:16

update from comments

6affb81

more updates..

f4e9e0c

fix rebase

f54d8d8

fix pesky type errors

ee02a5a

test fixes

48a061d

lint fix

5399ccc

Update superset-frontend/spec/javascripts/views/CRUD/welcome/Welcome_…

5a335e3

…spec.tsx Co-authored-by: Evan Rusackas <evan@preset.io>

Update superset-frontend/src/views/CRUD/welcome/EmptyState.tsx

3199924

Co-authored-by: Evan Rusackas <evan@preset.io>

Update superset-frontend/src/components/Menu/SubMenu.tsx

0b72ef8

Co-authored-by: Evan Rusackas <evan@preset.io>

Update superset-frontend/src/components/ListViewCard/index.tsx

7af5abb

Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>

Update superset-frontend/src/components/ListViewCard/index.tsx

68d4081

Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>

add suggestions

8af7bd2

fix lint

596471a

remove unused code

2f7744b

toast getrecentActivityobjs

ace8055

add some suggestions

e3d94c4

pkdotson force-pushed the home-screen-mvp branch from cff32e2 to e3d94c4 Compare October 29, 2020 23:05

pkdotson added 3 commits October 29, 2020 16:13

remove types for now

ff22e81

cypress fix

09ff645

remove unused type

3af819d

pkdotson requested review from rusackas and nytai October 30, 2020 03:07

rusackas approved these changes Oct 30, 2020

View reviewed changes

rusackas merged commit f7051ea into apache:master Oct 30, 2020

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: home screen mvp #11206

feat: home screen mvp #11206

pkdotson commented Oct 8, 2020 •

edited

Loading

codecov-io commented Oct 8, 2020 •

edited

Loading

rusackas left a comment

rusackas commented Oct 22, 2020

nytai Oct 27, 2020

nytai commented Oct 27, 2020

rusackas commented Oct 29, 2020

rusackas left a comment

ktmud commented Oct 30, 2020

junlincc commented Oct 30, 2020

feat: home screen mvp #11206

feat: home screen mvp #11206

Conversation

pkdotson commented Oct 8, 2020 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

codecov-io commented Oct 8, 2020 • edited Loading

Codecov Report

rusackas left a comment

Choose a reason for hiding this comment

rusackas commented Oct 22, 2020

nytai Oct 27, 2020

Choose a reason for hiding this comment

nytai commented Oct 27, 2020

rusackas commented Oct 29, 2020

rusackas left a comment

Choose a reason for hiding this comment

ktmud commented Oct 30, 2020

junlincc commented Oct 30, 2020

pkdotson commented Oct 8, 2020 •

edited

Loading

codecov-io commented Oct 8, 2020 •

edited

Loading