Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(api): improve API info performance #11346

Merged
merged 1 commit into from Oct 22, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Oct 20, 2020

SUMMARY

FAB's _info endpoint serves several information: permissions, filters, add fields, edit fields etc, by default fetches them all.
This change increases performance on this API call by just fetching permissions, note that this is hit on every React list view load

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #11346 into master will decrease coverage by 9.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11346      +/-   ##
==========================================
- Coverage   65.75%   56.40%   -9.35%     
==========================================
  Files         838      406     -432     
  Lines       39714    13459   -26255     
  Branches     3613     3404     -209     
==========================================
- Hits        26115     7592   -18523     
+ Misses      13498     5697    -7801     
- Partials      101      170      +69     
Flag Coverage Δ
#cypress 56.40% <ø> (ø)
#javascript ?
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/hooks.ts 51.80% <ø> (-24.60%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx 3.57% <0.00%> (-93.73%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-89.19%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
... and 654 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7369039...371c9d4. Read the comment docs.

@dpgaspar dpgaspar merged commit 85e28dd into apache:master Oct 22, 2020
@dpgaspar dpgaspar deleted the perf/api-info-permissions branch October 22, 2020 07:55
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants