Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump pypi cryptography from 2.4.2 to 3.2.1 #11511

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

mistercrunch
Copy link
Member

SUMMARY

title ^^^

@codecov-io
Copy link

codecov-io commented Oct 31, 2020

Codecov Report

Merging #11511 into master will decrease coverage by 4.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11511      +/-   ##
==========================================
- Coverage   66.57%   62.18%   -4.39%     
==========================================
  Files         873      873              
  Lines       41777    41771       -6     
  Branches     3826     3826              
==========================================
- Hits        27814    25977    -1837     
- Misses      13861    15615    +1754     
- Partials      102      179      +77     
Flag Coverage Δ
cypress ?
javascript 62.64% <ø> (ø)
python 61.91% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupPluginsExtra.js 0.00% <0.00%> (-100.00%) ⬇️
... and 180 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ae29e...06c07f6. Read the comment docs.

@@ -75,7 +75,7 @@ def get_git_sha():
"colorama",
"contextlib2",
"croniter>=0.3.28",
"cryptography>=2.4.2",
"cryptography>=3.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could potentially add , <4.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're pinned under requirements/ I don't think it's necessary. I'd pin if we'd know for sure that there's a backward-incompatible that is actually affecting us. Many times despite semver saying we may be affected, we're actually not.

@mistercrunch
Copy link
Member Author

BTW, just a thought but we may want to reconsider poetry as it seems to be gaining traction, and I'm guessing it may work for us.

@mistercrunch mistercrunch merged commit 9a1fcc7 into apache:master Oct 31, 2020
@mistercrunch mistercrunch deleted the bump_crypto branch October 31, 2020 20:28
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants