Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filters for alerts and reports list view #11900

Merged
merged 4 commits into from
Dec 4, 2020

Conversation

lilykuang
Copy link
Member

SUMMARY

  • implemented filters for alerts and reports list view

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-12-02 at 12 20 58 PM

Screen Shot 2020-12-02 at 12 21 03 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #11900 (461ed89) into master (721f911) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11900      +/-   ##
==========================================
- Coverage   63.78%   63.59%   -0.20%     
==========================================
  Files         927      462     -465     
  Lines       45006    28433   -16573     
  Branches     4308        0    -4308     
==========================================
- Hits        28708    18082   -10626     
+ Misses      16120    10351    -5769     
+ Partials      178        0     -178     
Flag Coverage Δ
javascript ?
python 63.59% <100.00%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/api.py 84.21% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.44%) ⬇️
superset/db_engine_specs/presto.py 69.95% <0.00%> (-12.34%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 96.51% <0.00%> (-2.33%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 87.33% <0.00%> (-1.62%) ⬇️
superset/sql_lab.py 79.62% <0.00%> (-0.67%) ⬇️
... and 482 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 721f911...461ed89. Read the comment docs.

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

'created_by',
createErrorHandler(errMsg =>
t(
'An error occurred while fetching dataset datasource values: %s',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'An error occurred while fetching dataset datasource values: %s',
'An error occurred while fetching created by values: %s',

Header: t('Created By'),
id: 'created_by',
input: 'select',
operator: 'rel_o_m',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add these to an enum a recently (https://github.com/apache/incubator-superset/blob/1842c56209131757f47bf7706a601aa933c6da4b/superset-frontend/src/components/ListView/types.ts#L103) can we use that as we do in QueryList which should make their meaning a little less ambiguous.

@nytai nytai merged commit 60122a2 into apache:master Dec 4, 2020
@nytai nytai deleted the lily/alert-report-filters branch December 4, 2020 17:58
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants