Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add modal to import charts #11956

Merged
merged 2 commits into from Dec 8, 2020
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

This is #11923, which I messed up while rebasing.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #11956 (8b86183) into master (2b9695c) will decrease coverage by 3.94%.
The diff coverage is 70.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11956      +/-   ##
==========================================
- Coverage   67.70%   63.75%   -3.95%     
==========================================
  Files         938      940       +2     
  Lines       45437    45576     +139     
  Branches     4358     4378      +20     
==========================================
- Hits        30761    29055    -1706     
- Misses      14573    16344    +1771     
- Partials      103      177      +74     
Flag Coverage Δ
cypress ?
javascript 62.91% <61.83%> (-0.01%) ⬇️
python 64.24% <95.34%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx 57.57% <ø> (ø)
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 69.10% <45.00%> (-14.54%) ⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 68.58% <61.53%> (-0.65%) ⬇️
...rontend/src/chart/components/ImportModal/index.tsx 65.30% <65.30%> (ø)
...nd/src/datasource/components/ImportModal/index.tsx 65.30% <65.30%> (ø)
superset/charts/commands/importers/v1/__init__.py 93.25% <85.71%> (-0.65%) ⬇️
...uperset/datasets/commands/importers/v1/__init__.py 92.20% <85.71%> (-0.65%) ⬇️
superset/charts/api.py 80.53% <100.00%> (+0.06%) ⬆️
superset/charts/commands/importers/dispatcher.py 80.64% <100.00%> (+1.33%) ⬆️
superset/charts/schemas.py 100.00% <100.00%> (ø)
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbb458f...8b86183. Read the comment docs.

Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@betodealmeida betodealmeida merged commit 33325f9 into apache:master Dec 8, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants