Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] adding 'superset flower' command (flower is a UI for Celery) #2963

Merged
merged 2 commits into from Jun 16, 2017
Merged

[CLI] adding 'superset flower' command (flower is a UI for Celery) #2963

merged 2 commits into from Jun 16, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jun 14, 2017 •
edited

Also:

  • fixing Celery to truly use the configuration object (was using only one param)
  • adding some color to the CLI

screen shot 2017-06-13 at 10 05 41 pm

timfeirg
timfeirg reviewed Jun 14, 2017
View reviewed changes
superset/cli.py Outdated
@@ -21,6 +22,12 @@
manager.add_command('db', MigrateCommand)


def get_celery_app():
app = celery.current_app._get_current_object()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey quick question, isn't it safe to just use current_app here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    app = celery.current_app
    app.config_from_object(...)
    return app

like this maybe?

@yolken
Copy link
Contributor

yolken commented Jun 15, 2017

LGTM

@mistercrunch mistercrunch merged commit 7122974 into apache:master Jun 16, 2017
@mistercrunch mistercrunch deleted the flower branch June 16, 2017 00:02
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfeirg timfeirg timfeirg left review comments

@ascott ascott Awaiting requested review from ascott

@yolken yolken Awaiting requested review from yolken

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mistercrunch @yolken @timfeirg