add test coverage for ResultSet component #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascott
reviewed
Jun 15, 2017
| it('is valid', () => { | ||
| expect(React.isValidElement(<ResultSet {...mockedProps} />)).to.equal(true); | ||
| }); | ||
| it('renders a Table', () => { | ||
| const wrapper = shallow(<ResultSet {...mockedProps} />); | ||
| expect(wrapper.find(FilterableTable)).to.have.length(1); | ||
| }); | ||
| describe('getControls', () => { |
There was a problem hiding this comment.
this could be an it block rather than describe. typically describe would wrap multiple it blocks.
might be more clear as it('sets correct class name given props', () => {});
There was a problem hiding this comment.
i added another it block, so we test both controls view and noControls view.
|
1 small comment, but otherwise LGTM! |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2859