[bugfix] Datasource -> Slice relationship #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianmenges
changed the title
fabianmenges
force-pushed
the
datasource_fix
branch
from
eb98ed4
to
bddba4e
Compare
fabianmenges
commented
Jun 21, 2017
| 'Slice', | ||
| primaryjoin=( | ||
| "DruidDatasource.id == foreign(Slice.datasource_id) and " | ||
| "Slice.datasource_type == 'druid'")) |
There was a problem hiding this comment.
To be clear, this filter on 'druid' currently does not do anything.
This was referenced Jun 24, 2021
This was referenced Aug 4, 2021
This was referenced Sep 1, 2021
mistercrunch
added
🏷️ bot
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing slices relationship does not filter correctly on the
datasource_type.Currently, if you delete a druid datasource, it will set
datasource_idon all slices toNULLwhere the druid datasource id matches thatdatasource_id, even if the slice was referencing a sql table id.