[hotfix] backward compatibility on date expressions #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously all 'since' date expression evaluated in the future like `30 days` would be reassigned to the past (now - `30 days`). It would extend to fixed dates which is a bad thing and was removed. Now we have reports and dashboards in the wild that use things like `30 days` and we'd like to not break those as we roll out the next version. This fix should allow for that.
|
hotfix, mergin' |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all 'since' date expression evaluated in the future like
30 dayswould be reassigned to the past (now -30 days). It wouldextend to fixed dates which is a bad thing and was removed.
Now we have reports and dashboards in the wild that use things like
30 daysand we'd like to not break those as we roll out the next version.This fix should allow for that.