Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql lab] fix encoding error in logging message #3424

Merged
merged 1 commit into from
Sep 14, 2017

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Sep 6, 2017

In Sql Lab, user types in a query with unicode like this:

SELECT * FROM "tb_name" WHERE city = "Lübeck"

When sql_parse.py and sql_lab.py tried to log message like:
logging.info("Parsing with sqlparse statement {}".format(self.sql))
This cause exception thrown, and user got Internal Server Error from Sql Lab.

@coveralls
Copy link

coveralls commented Sep 7, 2017

Coverage Status

Coverage decreased (-0.2%) to 68.9% when pulling 7ad234ab6e2717db82ed30dc32676af8a7534d53 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master.

@coveralls
Copy link

coveralls commented Sep 7, 2017

Coverage Status

Coverage decreased (-0.2%) to 68.9% when pulling 7ad234ab6e2717db82ed30dc32676af8a7534d53 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master.

@coveralls
Copy link

coveralls commented Sep 7, 2017

Coverage Status

Coverage decreased (-0.2%) to 68.961% when pulling d8a769fc3dec5e74624ae62a5da266dbcba1b247 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 68.961% when pulling b27b5bf70dbfbaa2ad0fe919abca2f3a88172ce5 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 68.961% when pulling b27b5bf70dbfbaa2ad0fe919abca2f3a88172ce5 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master.

@graceguo-supercat graceguo-supercat force-pushed the gg-SQLlabEncoding branch 2 times, most recently from b2075e8 to 786b12f Compare September 7, 2017 20:12
@coveralls
Copy link

coveralls commented Sep 7, 2017

Coverage Status

Coverage increased (+0.005%) to 69.123% when pulling 786b12ff28c1bf40312f430d907cb856619d3ae3 on graceguo-supercat:gg-SQLlabEncoding into 3dfdde1 on apache:master.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> dedup(['foo', 'bar', 'bar', 'bar']) to

>>> len(dedup(['foo', 'bar', 'bar', 'bar']))
4

@coveralls
Copy link

coveralls commented Sep 12, 2017

Coverage Status

Coverage decreased (-0.2%) to 68.962% when pulling b8b5ea9122a7c186dc3ce54a545097e180e3a00f on graceguo-supercat:gg-SQLlabEncoding into 8223729 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 69.129% when pulling eeb6b86 on graceguo-supercat:gg-SQLlabEncoding into 8223729 on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 12, 2017

Coverage Status

Coverage increased (+0.009%) to 69.129% when pulling eeb6b86 on graceguo-supercat:gg-SQLlabEncoding into 8223729 on apache:master.

@mistercrunch mistercrunch merged commit ad604ae into apache:master Sep 14, 2017
@mistercrunch mistercrunch deleted the gg-SQLlabEncoding branch September 14, 2017 18:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants