Fixed dashboard filters carrying over to explore slice #3461
Conversation
| href={getExploreUrl(slice.form_data, 'csv')} | ||
| title="Export CSV" | ||
| data-toggle="tooltip" | ||
| > |
There was a problem hiding this comment.
Are these lines the same as in master, but formatted differently?
There was a problem hiding this comment.
className was added, and eslint wants the code formatted this way when having it on one line would exceed 100 characters
| href={getExploreUrl(slice.form_data)} | ||
| title="Explore chart" | ||
| data-toggle="tooltip" | ||
| > |
| const formDataExtra = Object.assign({}, formData); | ||
| const extraFilters = controller.effectiveExtraFilters(sliceId); | ||
| formDataExtra.filters = formDataExtra.filters.concat(extraFilters); | ||
| controls.find('a.exploreChart').attr('href', getExploreUrl(formDataExtra)); |
There was a problem hiding this comment.
Does not look a very react-ish way to handle this, shouldn't the component that renders the link should take formDataExtra and render again when it changes?
There was a problem hiding this comment.
@xrmx eventually this whole module will get refactored out as we write a 100% React dashboard app (currently we have a lot of non-react JS in that app...), this is ok as is for now. We'll have to nuke all the jQuery code out of there in the future...
|
|
mistercrunch
added
🏷️ bot
To fix issue #3172
Solution