Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After saving slice fixing redirect #3572

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

michellethomas
Copy link
Contributor

When saving a slice and going to a dashboard, the redirect to the dashboard url is breaking. We were redirecting to data.slice.slice_url but data was a string when goto_dashboard is true.

@graceguo-supercat was thinking it may be useful to always return the full slice object, but I can also just return {'dashboard': dash.url} instead of adding it to the response.

Thanks for the help @graceguo-supercat

@coveralls
Copy link

coveralls commented Oct 3, 2017

Coverage Status

Coverage increased (+0.004%) to 70.145% when pulling 5723b14 on michellethomas:mt_fix_save_slice into f8cc05b on apache:master.

@mistercrunch
Copy link
Member

Thanks for the fix! Mergin'

@mistercrunch mistercrunch merged commit 064363d into apache:master Oct 3, 2017
michellethomas added a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants