Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to add oracle view as superset table. #3658

Closed
3 tasks
modastyle opened this issue Oct 12, 2017 · 3 comments
Closed
3 tasks

failed to add oracle view as superset table. #3658

modastyle opened this issue Oct 12, 2017 · 3 comments
Labels
inactive Inactive for >= 30 days need:more-info Requires more information from author

Comments

@modastyle
Copy link

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

2.0.3

Expected results

Failed to add oracle view as superset table, while it works normal at the vresion of 1.9.1.

Actual results

Steps to reproduce

Open the tablemodelview list page, click add table button, then go to the add table page, try to add an oracle view, it will fail.

@xrmx
Copy link
Contributor

xrmx commented Oct 12, 2017

Check the superset logs and include any stacktrace please.

@mistercrunch mistercrunch added the need:more-info Requires more information from author label Oct 13, 2017
@hidetoshiito
Copy link
Contributor

Hi

I also have the same problem.

I worked after fixing it like this.
It is workaround.
I do not understand the implementation of it, so I can not fix it.

/superset/connectors/sqla/views.py
L.237

         # Fail before adding if the table can't be found
-        if not table.database.has_table(table):  
+       try:
+           table.get_sqla_table_object()         
+       except Exception as e:
             raise Exception(_( 

Superset version

0.20.5

Actual results

An error message
Table [OracleScheme.ViewName] could not be found please double check your database connection, schema, and table name

hidetoshiito added a commit to hidetoshiito/incubator-superset that referenced this issue Dec 28, 2017
rollback to old version
mistercrunch pushed a commit that referenced this issue Apr 11, 2018
* BugFix(#3658)

rollback to old version

* Update views.py
michellethomas pushed a commit to michellethomas/panoramix that referenced this issue May 24, 2018
* BugFix(apache#3658)

rollback to old version

* Update views.py
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this issue May 31, 2018
* BugFix(apache#3658)

rollback to old version

* Update views.py
wenchma pushed a commit to wenchma/incubator-superset that referenced this issue Nov 16, 2018
* BugFix(apache#3658)

rollback to old version

* Update views.py
@stale
Copy link

stale bot commented Apr 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days need:more-info Requires more information from author
Projects
None yet
Development

No branches or pull requests

4 participants