New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the ISO code description of region/province/department #3685

Merged

mistercrunch merged 3 commits into apache:master from roganw:fix_region_code

Oct 25, 2017

Contributor

roganw commented Oct 18, 2017 •

edited

Referring to ISO 3166-2, the codes of region/province/department are defined by ISO 3166-2.

roganw added 3 commits

October 18, 2017 10:25


          Fix the ISO code description of region/province/department

fc87440


           Missing the data of one province and two regions of China

abff455


          Revert " Missing the data of one province and two regions of China"

11677f9

This reverts commit abff455.

coveralls commented Oct 18, 2017 •

edited

Coverage remained the same at 70.757% when pulling abff455 on roganw:fix_region_code into e121a85 on apache:master.

coveralls commented Oct 18, 2017

Coverage remained the same at 70.757% when pulling 11677f9 on roganw:fix_region_code into e121a85 on apache:master.

2 similar comments

coveralls commented Oct 18, 2017

Coverage remained the same at 70.757% when pulling 11677f9 on roganw:fix_region_code into e121a85 on apache:master.

coveralls commented Oct 18, 2017 •

edited

Coverage remained the same at 70.757% when pulling 11677f9 on roganw:fix_region_code into e121a85 on apache:master.

coveralls commented Oct 18, 2017 •

edited

Coverage remained the same at 70.757% when pulling 11677f9 on roganw:fix_region_code into e121a85 on apache:master.

1 similar comment

coveralls commented Oct 18, 2017 •

edited

Coverage remained the same at 70.757% when pulling 11677f9 on roganw:fix_region_code into e121a85 on apache:master.

mistercrunch merged commit 547a3bf into apache:master

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request


          Fix the ISO code description of region/province/department (apache#3685)

c7906dd

* Fix the ISO code description of region/province/department

*  Missing the data of one province and two regions of China

* Revert " Missing the data of one province and two regions of China"

This reverts commit abff455.

mistercrunch added 🏷️ bot 🚢 0.20.5 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment