Renaming files to allow RPM build #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging in updates from main repo
updating my fork
I was having issues getting an RPM to build. My error was Processing files: superset-0.20.1-1.noarch error: File must begin with "/": Lockup error: File must begin with "/": With error: File must begin with "/": Text.svg error: File must begin with "/": Lockup error: File must begin with "/": With error: File must begin with "/": Text@2x.png error: File must begin with "/": Lockup error: File must begin with "/": Without error: File must begin with "/": Text@1x.svg error: File must begin with "/": Lockup error: File must begin with "/": Without error: File must begin with "/": Text@2x.png error: File must begin with "/": Mark.png error: File must begin with "/": Mark@1x.svg for ref pypa/setuptools#767 File renaming fixes this issue
|
Do we need these files? Looks like they are not referenced anywhere. |
|
Anyway the error looks like some missing quoting |
|
I don't see them being used. However, when bdist is running rpmbuild the spaces cause the issue. I can change to delete the files all together if that is better.
|
|
Happy to merge, those assets are really just in the repo for reference and could live some place else. That reminds me that I should print a bunch of Superset tshirts! |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
I was having issues getting an RPM to build. My error was Processing files: superset-0.20.1-1.noarch error: File must begin with "/": Lockup error: File must begin with "/": With error: File must begin with "/": Text.svg error: File must begin with "/": Lockup error: File must begin with "/": With error: File must begin with "/": Text@2x.png error: File must begin with "/": Lockup error: File must begin with "/": Without error: File must begin with "/": Text@1x.svg error: File must begin with "/": Lockup error: File must begin with "/": Without error: File must begin with "/": Text@2x.png error: File must begin with "/": Mark.png error: File must begin with "/": Mark@1x.svg for ref pypa/setuptools#767 File renaming fixes this issue
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
I was having issues getting an RPM to build. My error was Processing files: superset-0.20.1-1.noarch error: File must begin with "/": Lockup error: File must begin with "/": With error: File must begin with "/": Text.svg error: File must begin with "/": Lockup error: File must begin with "/": With error: File must begin with "/": Text@2x.png error: File must begin with "/": Lockup error: File must begin with "/": Without error: File must begin with "/": Text@1x.svg error: File must begin with "/": Lockup error: File must begin with "/": Without error: File must begin with "/": Text@2x.png error: File must begin with "/": Mark.png error: File must begin with "/": Mark@1x.svg for ref pypa/setuptools#767 File renaming fixes this issue
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues getting an RPM to build. My error was
Processing files: superset-0.20.1-1.noarch
error: File must begin with "/": Lockup
error: File must begin with "/": With
error: File must begin with "/": Text.svg
error: File must begin with "/": Lockup
error: File must begin with "/": With
error: File must begin with "/": Text@2x.png
error: File must begin with "/": Lockup
error: File must begin with "/": Without
error: File must begin with "/": Text@1x.svg
error: File must begin with "/": Lockup
error: File must begin with "/": Without
error: File must begin with "/": Text@2x.png
error: File must begin with "/": Mark.png
error: File must begin with "/": Mark@1x.svg
for ref pypa/setuptools#767
File renaming fixes this issue