[country_map] use Albers USA projection #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
While I love the new USA map format, I'm sorry to report that it does not appear to work. I've confirmed that a chart which previously worked fine with the old map no longer shows any data with these changes. The data is a simple map containing ISO-3166-2 region codes and values (US-GA, US-CT, etc.) Reverting this change fixes the problem for me. I've attached a .csv containing sample data that can be used to replicate the problem. Just import and set query to user_region with metric sum_pageviews. If there's anything else I can provide to help - just let me know. |
|
Submitted problem as issue #4112 |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [country_map] use Albers USA projection * Minor touchups * Adding color scheme
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [country_map] use Albers USA projection * Minor touchups * Adding color scheme
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after
Also added ability to set number formatting a new spectrum color scheme.