Improving speed of dashboard import #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellethomas
force-pushed
the
fix_dashboard_import
branch
from
7ac906e
to
99feaf9
Compare
|
LGTM once the tests pass |
michellethomas
force-pushed
the
fix_dashboard_import
branch
from
ac09674
to
4c112b3
Compare
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Improve dashboard import * Updating tests for Slice.import_obj
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Improve dashboard import * Updating tests for Slice.import_obj
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import dashboard function slows times out when you try to import too many dashboards or slices. This is a first pass at improving the performance.
Previously for every slice import we were looping over all slices to see if it's remote id matched the slice_to_import.id. Now, once for each dashboard I build a dictionary that has remote_id to Slice and look up the each slice's id in the mapping dictionary.
This speeds things up from 2-3 seconds per slice to < 1 second per slice.
@john-bodley @mistercrunch