[sql lab] deeper support for templating #3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mistercrunch
commented
Dec 4, 2017
mistercrunch
commented
mistercrunch
force-pushed
the
template_params
branch
from
1dcb435
to
e082667
Compare
betodealmeida
approved these changes
Dec 15, 2017
| @@ -2161,6 +2161,8 @@ def sql_json(self): | |||
| sql = request.form.get('sql') | |||
| database_id = request.form.get('database_id') | |||
| schema = request.form.get('schema') or None | |||
| template_params = json.loads( | |||
| request.form.get('templateParams') or '{}') | |||
There was a problem hiding this comment.
get takes a default parameter:
template_params = json.loads(request.form.get('templateParams', '{}'))There was a problem hiding this comment.
The intent of the or is to handle an existing key with an empty string value, though I could probably trim
| renderDoc() { | ||
| return ( | ||
| <p> | ||
| Assign a set of parameters as <code>JSON</code> bellow |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [sql lab] deeper support for templating * Fixing py tests * Fix typo
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [sql lab] deeper support for templating * Fixing py tests * Fix typo
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.