[sql lab] fix position of 'save query' Popover #3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Save Query" popover renders on the upper left corner as opposed to where it should (relative to the Save Query button). After a bit of research, it seems like Popover won't render in the right place when parents are absolute. I'm guessing this stopped working properly when I added the resizable panes. Anyhow, the solution here is to use a modal instead.
mistercrunch
force-pushed
the
fix_sqllab_save_popover
branch
from
be926d3
to
b11e5d8
Compare
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [sql lab] fix position of 'save query' Popover The "Save Query" popover renders on the upper left corner as opposed to where it should (relative to the Save Query button). After a bit of research, it seems like Popover won't render in the right place when parents are absolute. I'm guessing this stopped working properly when I added the resizable panes. Anyhow, the solution here is to use a modal instead. * Fixing tests
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [sql lab] fix position of 'save query' Popover The "Save Query" popover renders on the upper left corner as opposed to where it should (relative to the Save Query button). After a bit of research, it seems like Popover won't render in the right place when parents are absolute. I'm guessing this stopped working properly when I added the resizable panes. Anyhow, the solution here is to use a modal instead. * Fixing tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Save Query" popover renders on the upper left corner as opposed to
where it should (relative to the Save Query button). After a bit of
research, it seems like Popover won't render in the right place when
parents are absolute.
I'm guessing this stopped working properly when I added the resizable
panes.
Anyhow, the solution here is to use a modal instead.