[Bugfix] Postaggregations depending on postaggregations #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mogball
force-pushed
the
jeff/druid_tuple_sketch
branch
2 times, most recently
from
170adc0
to
8753672
Compare
Mogball
force-pushed
the
jeff/druid_tuple_sketch
branch
from
8753672
to
ac2cb53
Compare
|
Nice, I noticed that a while back. |
|
Awesome! We need this fix too. |
|
Looks solid, merging. BTW longer term fix is to go with Druid SQL on this. Composing expressions is going to be so much easier. |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Druid post-aggregations can depend on other post-aggregations in their
fieldNames, but current behaviour will treat them all asaggregations. Also, post-aggregation order is important because a dependent post-aggregation needs to be defined after post-aggregations it depends on.This fix will cause superset to search for postaggregations and then aggregations.