[sql_lab] Handle PyHive DatabaseError format #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should send the entire call stack to the client side. Thats generally bad practice specifically for security reasons. Errors should be logged on the application side. |
|
@fabianmenges that is what this pr is about. It sends only the message now. |
dmigo
changed the title
dmigo
changed the title
|
Ah... sorry, I can't read. LGTM |
fabianmenges
approved these changes
Dec 6, 2017
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4013
Converts this:
into this:
Current implementation is based on what is available in debugger when running superset locally. Plus on the current implementation of the PyHive.
Not sure where the current approach comes from, but I left it there since according to @mistercrunch it seems to still work in some cases.