Make Welcome page into a simple React app #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a dependency on datatables, we should be able to get rid of it as we re-write the Table and PivotTable viz
mistercrunch
force-pushed
the
fix_welcome
branch
3 times, most recently
from
1d94847
to
0db4dae
Compare
mistercrunch
force-pushed
the
fix_welcome
branch
from
0db4dae
to
20d77dc
Compare
graceguo-supercat
approved these changes
Jan 7, 2018
|
@graceguo-supercat it's the exact same JSON endpoint as before so it should be ok |
xiaohanyu
pushed a commit
to xiaohanyu/incubator-superset
that referenced
this pull request
Jan 24, 2018
As in apache#4147 removes the final non fluid container navbar, I think there's no need to keep this line of code. Just use navbar with fluid container, always.
mistercrunch
pushed a commit
that referenced
this pull request
Jan 24, 2018
As in #4147 removes the final non fluid container navbar, I think there's no need to keep this line of code. Just use navbar with fluid container, always.
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Make Welcome page into a simple React app This removes a dependency on datatables, we should be able to get rid of it as we re-write the Table and PivotTable viz * tests/lint * Bump node version to latest
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
As in apache#4147 removes the final non fluid container navbar, I think there's no need to keep this line of code. Just use navbar with fluid container, always.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Make Welcome page into a simple React app This removes a dependency on datatables, we should be able to get rid of it as we re-write the Table and PivotTable viz * tests/lint * Bump node version to latest
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
As in apache#4147 removes the final non fluid container navbar, I think there's no need to keep this line of code. Just use navbar with fluid container, always.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with
Modifiedcolumn sorting on the human-readable string instead of underlying date and removes a dependency on datatables, we should be able to get rid of it as we re-write the Table and PivotTable vizBefore
After