Fix chart rendering error in time series table #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know that we want to automatically reset the lag time (even if the number of days they set the lag to is not available) because it would make the data shown not what the user expected. What about showing a better error message (The time lag set at 361 days exceeds the length of data at 360 days. Please reduce the time lag)? |
graceguo-supercat
force-pushed
the
gg-FixTimeLagError
branch
from
3ccfbfd
to
5951d21
Compare
graceguo-supercat
force-pushed
the
gg-FixTimeLagError
branch
from
5951d21
to
c55fd67
Compare
|
fixed according to @michellethomas's comment. thank you! |
|
lgtm |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In time series table chart, when total number of available lags less than timeLag param, we see JS rendering error.
