[datasource editor] click checkbox creates metrics instantly #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianmenges
reviewed
Jan 9, 2018
| metrics = [] | ||
| M = SqlMetric # noqa | ||
| quoted = self.column_name | ||
| if self.sum: |
There was a problem hiding this comment.
Should we delete the metrics that were 'unselected'?
There was a problem hiding this comment.
I didn't want to risk it as metrics may be used in charts and users may create issues. User then have to both uncheck and explicitly delete the metric.
mistercrunch
force-pushed
the
fix_metrics_d
branch
from
40e3153
to
e40b265
Compare
mistercrunch
force-pushed
the
fix_metrics_d
branch
from
e40b265
to
67ebf7e
Compare
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…4183) * [datasource editor] click checkbox creates metrics instantly * Fix tests
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…4183) * [datasource editor] click checkbox creates metrics instantly * Fix tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes checkboxes on the Druid datasource editor, it was showing
True/Falsebefore.