[line chart] fix time shift color #4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
reviewed
Jan 12, 2018
superset/viz.py
Outdated
| @@ -939,7 +939,7 @@ def to_series(self, df, classed='', title_suffix=''): | |||
| if isinstance(series_title, string_types): | |||
| series_title += title_suffix | |||
| elif title_suffix and isinstance(series_title, (list, tuple)): | |||
| series_title = series_title + (title_suffix,) | |||
| series_title = str(series_title[-1]) + title_suffix | |||
There was a problem hiding this comment.
Can the series title contain unicode characters? If so should this be six.text_type(...) rather than str(...) , or maybe use,
from builtins import str
mistercrunch
force-pushed
the
fix_time_shift_color
branch
from
4c78cd4
to
7e40d8a
Compare
|
LGTM |
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 18, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug occurs only when using a groupby, not when using only metrics only
before
after
closes #4198