Adding limit to time_table viz to get druid query to work #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 18, 2018
john-bodley
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jan 18, 2018
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Jan 19, 2018
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jan 19, 2018
Adding limit to time_table viz to get druid query to work (apache#4207)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jan 19, 2018
john-bodley
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jan 19, 2018
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@graceguo-supercat @john-bodley Adding the limit control on the time series table visualization.
[Update] Pulled out the description for the issue here. In short, the druid query for the time series table was incorrect because it required a limit to include the second part of the query.
I'm not as familiar with this part of the code so I'm just adding a temporary fix to get the time table viz working. But this also causes problems if you remove the
limiton a line chart.