Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sql Lab] Fix query results display cutoff at the bottom of screen #4246

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jan 19, 2018

When user has multiple tabs in sql lab, and switch tabs to see different query results, some results at the bottom of browser window will be cut-off (even with scrollbar).
@williaster @michellethomas

before:
screen shot 2017-11-13 at 11 43 55 am 4

after:
screen shot 2018-01-18 at 10 57 08 pm

@graceguo-supercat graceguo-supercat changed the title [Sql Lab] Fix query results display at the bottom of screen [Sql Lab] Fix query results display cutoff at the bottom of screen Jan 19, 2018
@mistercrunch
Copy link
Member

LGTM

@graceguo-supercat graceguo-supercat merged commit 7b76356 into apache:master Jan 19, 2018
@graceguo-supercat graceguo-supercat deleted the gg-FixSQLLabBottomTruncation branch January 19, 2018 18:53
john-bodley pushed a commit to john-bodley/superset that referenced this pull request Jan 25, 2018
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Jan 25, 2018
[Sql Lab] Fix query results display at the bottom of screen (apache#4246)
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants