[geo] Add JS controls to remaining layers #4272
Conversation
hughhhh
changed the title
There was a problem hiding this comment.
Running into a bit of a conflict with #4262 here. Let's make sure both PRs align.
| if (fd.js_datapoint_mutator) { | ||
| // Applying user defined data mutator if defined | ||
| const jsFnMutator = sandboxedEval(fd.js_datapoint_mutator); | ||
| data = data.map(jsFnMutator); |
There was a problem hiding this comment.
With my recent PR we moved to js_data_mutator instead of js_datapoint_mutator and the call goes data = jsFnMutator(data);
| ...d, | ||
| color: [c.r, c.g, c.b, 255 * c.a], | ||
| })); | ||
|
|
||
| if (fd.js_datapoint_mutator) { |
There was a problem hiding this comment.
Same comment as above. Related PR: #4262
| ...d, | ||
| color: [c.r, c.g, c.b, 255 * c.a], | ||
| })); | ||
|
|
||
| if (fd.js_datapoint_mutator) { |
|
@mistercrunch lets make sure #4262 goes in first |
|
Now that my changes are in |
| t('Javascript data point mutator'), | ||
| t('Define a javascript function that receives each data point and can alter it ' + | ||
| 'before getting sent to the deck.gl layer'), | ||
| js_data_mutator: jsFunctionControl( |
There was a problem hiding this comment.
Sorry I had not yet merge this change when I asked you to rebase earlier, now it's merge and you should re-re-rebase
This reverts commit 2384ad4.
* Update viz.py * added JS controls * add JS to grid layout * add JS to hexagon layer * added JS controls to screengrid * update to js_data_mutator controls * remove .map()
* Update viz.py * added JS controls * add JS to grid layout * add JS to hexagon layer * added JS controls to screengrid * update to js_data_mutator controls * remove .map()
mistercrunch
added
🏷️ bot
Added JS controls to remaining DeckGL layers
merged small bugfix with arc layer payload #4238
@mistercrunch